[DTrace-devel] [PATCH 5/7] test: Add d_path detail to xfail message

[Eugene Loh]

Patch withdrawn.  Thanks for the substitute patch.

On 12/20/23 10:31, Kris Van Hees wrote:
> On Tue, Aug 22, 2023 at 05:51:12PM -0400, eugene.loh at oracle.com wrote:
>> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> The problem is that this test is failing because we do not have d_path(), yet
> it would really be nice to have the remainder of the translated members tested.
> I would propose we put in a stub d_path() that always returns "<unknown>" and
> update the expdected results to reflect that.  Then, when d_path() gets a real
> implemented, the test will start failing again and we'll be reminder to update
> it with the correct expected output for a working d_path().
>
> Does that sound like a good plan?
>
>> ---
>>   test/unittest/io/tst.fds.d | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/test/unittest/io/tst.fds.d b/test/unittest/io/tst.fds.d
>> index b762e6ac..12c04cad 100644
>> --- a/test/unittest/io/tst.fds.d
>> +++ b/test/unittest/io/tst.fds.d
>> @@ -5,7 +5,7 @@
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>>   
>> -/* @@xfail: dtv2 */
>> +/* @@xfail: dtv2, d_path support needed for fi_dirname and fi_pathname */
>>   /* @@trigger: bogus-ioctl */
>>   /* @@trigger-timing: after */
>>   /* @@runtest-opts: -C $_pid */
>> -- 
>> 2.18.4
>>
>>