[DTrace-devel] [PATCH 2/3] test: usdt: multitrace: wipe out parsed commits properly

[Kris Van Hees]

On Wed, Feb 28, 2024 at 10:18:23PM +0000, Nick Alcock via DTrace-devel wrote:
> One of the things test/unittest/usdt/tst.multitrace.sh is trying to do is
> verify that dtprobed's reparsing of wrong-version parsed DOF works right.
> It does this by overwriting the parsed DOF with junk (which corresponds to a
> definitely-wrong version) and letting it reparse it.
> 
> Unfortunately after the revamp to put the parsed DOF in multiple files,
> the test was never adjusted, so it's failing to wipe out the parsed
> commits and this never got properly tested since then.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  test/unittest/usdt/tst.multitrace.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/unittest/usdt/tst.multitrace.sh b/test/unittest/usdt/tst.multitrace.sh
> index dc930b6275a9d..84cf1e8caa543 100755
> --- a/test/unittest/usdt/tst.multitrace.sh
> +++ b/test/unittest/usdt/tst.multitrace.sh
> @@ -125,7 +125,7 @@ ONE=$!
>  # a failure if it simply doesn't reparse at all.
>  if [[ $dtrace != "/usr/sbin/dtrace" ]] && [[ -n $dtprobed_pid ]]; then
>      sleep 1
> -    for parsed in $DTRACE_OPT_DOFSTASHPATH/stash/dof-pid/*/*/parsed; do
> +    for parsed in $DTRACE_OPT_DOFSTASHPATH/stash/dof-pid/*/*/parsed/*; do
>  	echo 'a' > $parsed
>      done
>      kill -USR2 $dtprobed_pid
> -- 
> 2.43.0.272.gce700b77fd
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel