[DTrace-devel] [PATCH v2 1/2] tests, io, scalars: use kallsyms instead of kallmodsyms where possible

[Kris Van Hees]

We still need a v3 posted?

On Tue, Feb 13, 2024 at 04:15:16PM +0000, Nick Alcock wrote:
> On 13 Feb 2024, Eugene Loh via DTrace-devel outgrape:
> 
> > Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
> > and...
> >
> > On 2/12/24 11:21, Nick Alcock wrote:
> >> io/tst.local2.sh works perfectly well with /proc/kallsyms with only a
> >> tiny change in field numbering, which lets this test pass on
> >> unmodified upstream kernels and kernels with the vmlinux.ranges
> >> patch too.
> >
> > Add: "Similarly, io/check_io_probe_args.sh also works fine with
> > kallsyms, without even any field change."
> 
> Ack, modulo the grammatical error :)
> 
> >> diff --git a/test/unittest/scalars/tst.misc.x b/test/unittest/scalars/tst.misc.x
> >> @@ -1,10 +1,10 @@
> >>   #!/bin/sh
> >>   -if ! $(grep -qw isofs /proc/kallmodsyms); then
> >> +if ! grep -qw ext4_dir_operations /proc/kallsyms; then
> >>       exit 1
> >>   fi
> >>   -if ! $(grep -qw ext4 /proc/kallmodsyms); then
> >> +if ! grep -qw isofs_dir_operations /proc/kallsyms; then
> >>       exit 1
> >>   fi
> >
> > Okay.? The reviewer notices you changed the order.? That's okay. Just curious.
> 
> Er, stupidity? :) fixed.
> 
> -- 
> NULL && (void)
>