[DTrace-devel] [PATCH v3 13/21] runtest: put the in-tree-testing DOF stash under /tmp/runtest.*

[Kris Van Hees]

This should simply be fixed in the earlier patch in the series "dtprobed, usdt:
move usdt probe creation/deletion to dtrace"

On Tue, Jan 16, 2024 at 09:13:09PM +0000, Nick Alcock via DTrace-devel wrote:
> Normally, the DOF stash goes under /run.  In-tree-tessting was putting it
> under build in the srcdir, but that might be a quite different filesystem
> from the tmpfs /run. In particular it might be an NFS filesystem, which
> breaks the directory unlinkat()s done by the DOF stash thanks to
> silly-renames.
> 
> Move it under the $tmpdir instead, which is usually /tmp, thus a tmpdir,
> with similar semantics to /run. (This has the downside that the DOF stash
> gets deleted after every test run, but the test runs should do quite
> enough cross-dtrace-run testing to find bugs -- they have so far, not a
> single dtprobed restart has fuond any bugs that weren't found by our
> other various tricks.)
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>  runtest.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/runtest.sh b/runtest.sh
> index f3fb3e343c81..eac6f49028ba 100755
> --- a/runtest.sh
> +++ b/runtest.sh
> @@ -563,10 +563,10 @@ if [[ -z $USE_INSTALLED ]]; then
>      helper_device="dtrace/test-$$"
>      # Pre-existing directories from earlier tests are just fine!
>      # dtprobed will clean things up.
> -    mkdir -p $(pwd)/build/run/dtrace
> -    dtprobed_flags="-n $helper_device -s$(pwd)/build/run/dtrace -F"
> +    mkdir -p $tmpdir/run/dtrace
> +    dtprobed_flags="-n $helper_device -s${tmpdir}/run/dtrace -F"
>      export DTRACE_DOF_INIT_DEVNAME="/dev/$helper_device"
> -    export DTRACE_OPT_DOFSTASHPATH="$(pwd)/build/run/dtrace"
> +    export DTRACE_OPT_DOFSTASHPATH="${tmpdir}/run/dtrace"
>  
>      if [[ -z $(eval echo $dtrace) ]]; then
>      	echo "No dtraces available." >&2
> -- 
> 2.43.0.272.gce700b77fd
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel