[DTrace-devel] [PATCH] tests, io: don't use /proc/kallmodsyms

[Nick Alcock]

On 5 Feb 2024, Eugene Loh via DTrace-devel said:

> Fair enough.
> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
>
> But:
>
> 1)  How about renaming to "test: Use kallsyms instead of kallmodsyms where possible".
>
> 2)  Don't single out local2 in the commit message.  E.g., the change in check_io_probe_args is independent of local2's use.  How
> about just:
>
>     Removing unnecessary dependencies on /proc/kallmodsyms
>     lets tests pass on unmodified upstream kernels and kernels
>     with the vmlinux.ranges patch too.

That implies that *all* such tests are fixed by this patch, which is
very much not the case: there are big tests like aggs/tst.aggmod*.sh and
the stuff in test/unittest/consumer, both of which need to check
vmlinux.ranges too if they are to continue to work at all, and which are
much more work to fix.

I fixed and indeed improved test/unittest/actions/symmod/tst.symmod.sh,
but I split that out into a separate commit too since other bugs needed
fixing at the same time before it could work.

> 3)  Remove the corresponding dependency in test/unittest/scalars/tst.misc.x as well.

Ack.

Fix coming, plz re-review since it's changed quite a lot!