[DTrace-devel] [oracle/dtrace-utils] 540739: fix a tiny comment niggle

[euloh]

  Branch: refs/heads/dev
  Home:   https://github.com/oracle/dtrace-utils
  Commit: 540739eb56ace3ba71e3cd114b56d6c02a2d9745
      https://github.com/oracle/dtrace-utils/commit/540739eb56ace3ba71e3cd114b56d6c02a2d9745
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M libdtrace/dt_open.c

  Log Message:
  -----------
  fix a tiny comment niggle

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Suggested-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: 8fcffe86552e85f7c9aef438e070fd31c2047a86
      https://github.com/oracle/dtrace-utils/commit/8fcffe86552e85f7c9aef438e070fd31c2047a86
  Author: eugene.loh at oracle.com <eugene.loh at oracle.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M test/unittest/types/err.D_CAST_INVAL.badcast.d

  Log Message:
  -----------
  test: Clean up bad-cast test

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 91b0ab36c8c1c023977662d4ee6c7aa1d43d4463
      https://github.com/oracle/dtrace-utils/commit/91b0ab36c8c1c023977662d4ee6c7aa1d43d4463
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M dtprobed/dtprobed.c
    M libcommon/uprobes.c
    M libcommon/uprobes.h
    M libdtrace/dt_prov_dtrace.c

  Log Message:
  -----------
  uprobes: don't grab the process over and over again

In a foolish quest to push knowledge of libproc out of dtprobed.c, I had
the lowest-level uprobe_spec_by_addr() function, that gets given an
address and needs to know what mapping it is part of also be the
function that grabs the process with libproc's Pgrab(). This seems neat,
but Pgrab() is *expensive*, and this is needlessly inefficient: all
probes for a given mapping are registered in one go, always, but we are
grabbing the mapping *and the pid* over and over again for every probe.

As a fix for this, lift the Pgrab()/Prelease() pair out of
uprobe_spec_by_addr() into process_dof() in dtprobed.  This massively
speeds up dtprobed when large numbers of probes are involved.

(We are still grabbing the process once per lump-of-DOF, but arranging
to grab it only once for all the DOF in a process is more complex, since
it requires us to maintain the grab across ioctl()s but not keep it for
too long even though we never get told when the initial splurge of DOF
contribution at process startup is about to be over.  We'll get there,
but not quite yet.)

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 17139036bf9b08477569270175486ea9fcfaadc2
      https://github.com/oracle/dtrace-utils/commit/17139036bf9b08477569270175486ea9fcfaadc2
  Author: Nick Alcock via DTrace-devel <dtrace-devel at oss.oracle.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M include/dtrace/universal.h

  Log Message:
  -----------
  headers: add missing <stdint.h>

include/dtrace/universal.h uses uint32_t and other <stdint.h> integral
types, so should include <stdint.h>.

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: e1f9dc7e5fba62b8f4c122176f7f5ddf028845e1
      https://github.com/oracle/dtrace-utils/commit/e1f9dc7e5fba62b8f4c122176f7f5ddf028845e1
  Author: Nick Alcock via DTrace-devel <dtrace-devel at oss.oracle.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M libdtrace/dt_subr.c

  Log Message:
  -----------
  subr: tiny header tweak

I hunted down inclusions of <libgen.h> that weren't needed. Most were in
code I was touching anyway, but this one was independent.

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 812ee41a797856cc38f6e98d5de4b4da92de223f
      https://github.com/oracle/dtrace-utils/commit/812ee41a797856cc38f6e98d5de4b4da92de223f
  Author: eugene.loh at oracle.com <eugene.loh at oracle.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M dtrace.spec

  Log Message:
  -----------
  Add nfs-utils to dtrace.spec

This dependency was already needed, at least for the test suite for
io-mount-nfs.sh and tst.nfs.sh.

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: a1d695a68b1a7f1961c1aa6f6dae171848fb0a2a
      https://github.com/oracle/dtrace-utils/commit/a1d695a68b1a7f1961c1aa6f6dae171848fb0a2a
  Author: eugene.loh at oracle.com <eugene.loh at oracle.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M libdtrace/dt_dis.c
    A test/unittest/disasm/tst.ann-endian.r
    A test/unittest/disasm/tst.ann-endian.sh

  Log Message:
  -----------
  Fix disasm for endian operations

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/fb1ce0571ba0...a1d695a68b1a