[DTrace-devel] [PATCH] fix a tiny comment niggle

Eugene Loh eugene.loh at oracle.com
Mon Sep 11 18:18:39 UTC 2023


Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

On 9/11/23 12:46, Kris Van Hees via DTrace-devel wrote:
> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> Suggested-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>   libdtrace/dt_open.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/libdtrace/dt_open.c b/libdtrace/dt_open.c
> index 17345418..52e5281f 100644
> --- a/libdtrace/dt_open.c
> +++ b/libdtrace/dt_open.c
> @@ -771,12 +771,7 @@ dt_vopen(int version, int flags, int *errp,
>   	for (i = 0; i < DTRACEOPT_MAX; i++)
>   		dtp->dt_options[i] = DTRACEOPT_UNSET;
>   
> -	/* FIXME: the default value of strsize must be set.
> -	 * In legacy DTrace, the value was read from the kernel
> -	 * in dt_options_load().  When string handling is done,
> -	 * we will introduce a real solution suitable for this
> -	 * version.  For now, just set it here.
> -	 */
> +	/* Set the default maximum string size. */
>   	dtp->dt_options[DTRACEOPT_STRSIZE] = 256;
>   
>   	/* Set the default dynamic variable space size. */



More information about the DTrace-devel mailing list