[DTrace-devel] [PATCH v2] Do not use :: in IPv6 addresses without zero-collapsing

Eugene Loh eugene.loh at oracle.com
Tue Sep 5 22:07:16 UTC 2023


Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

(I didn't get the patch post in my inbox.)

Anyhow, minor comments:

The text in the commit message:
     Rather than adding a special
     case in the output generation code for this, this patch adds a 
branch to
     a code block that simply outputs 8 words, separated by ':'.
is not needed since that mainly explains this implementation vis-a-vis a 
different implementation we are dropping.  The code itself is 
sufficiently clear.

There is a "zero-cord" that should be "zero-word."

For the "full" loop, another option is to make the loop go 8 
iterations.  Then back %r9 up by 1 before Ldone.  (There are arguments 
for and against that choice.)




More information about the DTrace-devel mailing list