[DTrace-devel] [PATCH 2/2] Implement the pcap action

[Eugene Loh]

On 10/10/23 17:33, Kris Van Hees wrote:

> On Tue, Oct 10, 2023 at 01:39:04PM -0400, Eugene Loh via DTrace-devel wrote:
>> On 10/10/23 00:35, Kris Van Hees wrote:
>>> On Mon, Oct 09, 2023 at 11:54:32PM -0400, Eugene Loh via DTrace-devel wrote:
>>>> I am not familiar with pcap...
>> In legacy DTrace, in dtrace/dtrace_probe.c, dtrace_probe_pcap() deals with
>> some complications around fragments.  Why are there no such complications in
>> this patch?
> Like your io provider patch, there are still some (uncommon) cases that are not
> fully covered.  In discussing this with Alan Maguire, we decided that the case
> of fragment reconstruction is sufficiently rare that this version is definitely
> the most important support that is needed.  Support for fragmented packets is
> a follow-up development.

Ah.  Worth mentioning in the commit message or even in dt_cg_act_pcap()?