[DTrace-devel] [PATCH v2 01/04] probe: propagate dt_probe_args_info() failures to dt_probe_info()

[Nick Alcock]

On 30 Nov 2023, Kris Van Hees uttered the following:

>> 	case DMODE_LIST:
>> [...]		if (g_cmdc == 0)
>> 			dtrace_probe_iter(g_dtp, NULL, list_probe, NULL);
>> 
>> 		dtrace_close(g_dtp);
>> 		return g_status;
>> 
>> ... exits early without printing the dtrace_errmsg. You might want to
>> check all the dtrace_probe_iter()s that call list_probe() for error
>> returns, perhaps?
>
> Err... the code you quote above and allegedly is not handling things right
> is *exactly* the code that the next patch fragment you quote below changes
> to actually output the error.

You're quite right. I don't know how on earth I managed to overlook
that. I think I managed to misread the code and think there were *three*
call sites, not two...

So,

Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

... sorry about that!