[DTrace-devel] [PATCH v2 2/4] test: fix check_result.sh

Nick Alcock nick.alcock at oracle.com
Thu Nov 2 13:13:52 UTC 2023


On 1 Nov 2023, Eugene Loh via DTrace-devel uttered the following:

> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

> I don't argue with the patch, but for my personal edification I'd like
> to understand the commit message better.  The pre-existing syntax
> seemed to have worked perfectly for me and I don't ever remember
> encountering the problem described.  Ah well.  The patch is fine
> regardless.

You don't get any actual runtest-visible error when this happens; the
tests don't fail, you just get a syntax error on stderr, and tests don't
fail that perhaps should have done. You need to look in the runtest.log
to see it.

It might be specific to some versions of bash or something, though I'd
be rather surprised if it was. This was on OL9, with bash 5.1.8.

> Also, s/shuold/should/.

Fixed!

-- 
NULL && (void)



More information about the DTrace-devel mailing list