[DTrace-devel] [PATCH] dtprobed: delete redundant conditional

[Kris Van Hees]

On Tue, May 30, 2023 at 04:13:08PM +0100, Nick Alcock via DTrace-devel wrote:
> We've just tested this condition: it cannot be false.
> 
> This was pointed out in an earlier review, but I forgot to commit it.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  dtprobed/dtprobed.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/dtprobed/dtprobed.c b/dtprobed/dtprobed.c
> index 73ed6ba10fdd8..de2472ae77533 100644
> --- a/dtprobed/dtprobed.c
> +++ b/dtprobed/dtprobed.c
> @@ -520,8 +520,7 @@ helper_ioctl(fuse_req_t req, int cmd, void *arg,
>  		/*
>  		 * Too much data is as bad as too little.
>  		 */
> -		if (userdata->state == DTP_IOCTL_DOFHDR &&
> -		    (in_bufsz > sizeof(dof_hdr_t))) {
> +		if (in_bufsz > sizeof(dof_hdr_t)) {
>  			errmsg = "DOF header size incorrect";
>  			fuse_log(FUSE_LOG_ERR, "%i: dtprobed: %s: %zi, not %zi\n",
>  				 pid, errmsg, in_bufsz, sizeof(dof_hdr_t));
> 
> base-commit: f543fa6706c0b31364356c01bf3de63e3cce8ad1
> prerequisite-patch-id: fa667248b7b02e92ee6b3807123ebcf2ac0acc38
> prerequisite-patch-id: 0cec5f1a31d528a493d6143644c1e6b78c7f403b
> prerequisite-patch-id: 1e1ced5fcec01a0c2e38d12f1ae5a124c8f93860
> prerequisite-patch-id: eb290f098e38981181d85240150e1713979dc505
> prerequisite-patch-id: c25b38ab68e815a63f064aff7496408684f94a36
> prerequisite-patch-id: b86eb7e00b5883a586bd4dc7143ab25094912288
> prerequisite-patch-id: 85d3c176dc4a7105e4f04dbcdb4ccbdf18741795
> prerequisite-patch-id: 94206b53a67820bb1c9e828c11e57a0cb36949b6
> prerequisite-patch-id: c5a64d246ff26047723e5e1a9c16b42a1d5fbf87
> prerequisite-patch-id: 89cf4c6b9242525883ac02bb8ef90856ef908d0f
> prerequisite-patch-id: 0992642ac657a1da617588a6d7b28f3669960374
> prerequisite-patch-id: e8a65c309b3eaf3341ceac421ef602bcc3f057fa
> prerequisite-patch-id: 4d38462a4bf2b242f8fcec3bf28f1ad97fa40ca7
> prerequisite-patch-id: 6430030eaa9b5f09eedf6d41b698549096905c56
> prerequisite-patch-id: aefef52e1438f34dd49e0cde010e791d96ef06d9
> prerequisite-patch-id: e2bbb33b358df9330190eeb9b1e1ec25bebf06a6
> prerequisite-patch-id: 01c7598ca4429c23f650f760fb9ee3809b340322
> prerequisite-patch-id: 5998403c58e4b48f0cb0d87971e553d2999421fc
> prerequisite-patch-id: 8766128335d133bdd548ed5978aa9eefeb6f7b6d
> prerequisite-patch-id: 35e83414bbe54be31fe7cc15c7d6368543cd4e8f
> prerequisite-patch-id: fe12afceb640e98f3e1c71915e005f114677b22c
> prerequisite-patch-id: 3793aeb5329f974f12647158fe55329f5a801d06
> prerequisite-patch-id: 334d947a1a22d821075ff599c9290623f4698302
> -- 
> 2.39.1.268.g9de2f9a303
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel