[DTrace-devel] [PATCH 1/3] test: tst.nested-unnamed-structs.d needs to be xfail pending binutils patch

[Eugene Loh]

On 5/26/23 15:32, Nick Alcock wrote:

> On 26 May 2023, Eugene Loh via DTrace-devel outgrape:
>> On 5/26/23 12:08, Nick Alcock via DTrace-devel wrote:
>>> On 26 May 2023, Kris Van Hees via DTrace-devel said:
>>>> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
>>> Reviewed-by: Nick Alcock <nick.alcock at oracle.com>
>>>
>>> (the patch is upstream and has been backported as far as binutils 2.40,
>>> but we can't rely on its being present yet.)
>> So someone could have 2.40 and see this xpass?  Does that mean that what this test really needs is a modification to its .x file
>> instead of an outright xfail?
> I suppose so -- but what would the .x file test?

binutils version number?

> All it could really do
> is, well, check for this bug, and then the .x file *becomes* the test :)
> really this is for later, to make sure we don't regress after it starts
> passing, so maybe just tag it unstable for now, and remove that once
> we've backported the fix (and everyone else can just run a modern
> binutils or backport the fix themselves).
>
> ... or we don't use this test at all and just rely on the tests already
> in binutils that check for this bug. But it did seem worthwhile checking
> for it later, once we're supposed to have the fix, to make sure the fix
> never goes away again.