[DTrace-devel] [PATCH 3/6] dtprobed: support DOF > 64KiB

[Nick Alcock]

On 25 May 2023, Eugene Loh via DTrace-devel said:
> Just in case we're looking at different things, I'm looking at:
>
>         /*
>          * Third call: validate the DOF length and stash it away.
>          */
>         if (userdata->state == DTP_IOCTL_DOFHDR) {
>                 /*
>                  * Too much data is as bad as too little.
>                  */
>                 if (userdata->state == DTP_IOCTL_DOFHDR &&
>                     (in_bufsz > sizeof(dof_hdr_t))) {
>
> It looks like we're checking userdata->state==DTP_IOCTL_DOFHDR twice.

Oh, I see your point. Yeah, that's redundant cut-and-paste residue from
a refactoring: I'll drop a commit eliminating the redundancy into the
next release.

-- 
NULL && (void)