[DTrace-devel] [PATCH 4/6] dtprobed: fix a tiny leak on an error path

[Kris Van Hees]

On Mon, May 22, 2023 at 09:20:15PM +0100, Nick Alcock via DTrace-devel wrote:
> Highly unlikely to be a problem, but still.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  dtprobed/dtprobed.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/dtprobed/dtprobed.c b/dtprobed/dtprobed.c
> index 01a30ab95129b..1bf621e200d58 100644
> --- a/dtprobed/dtprobed.c
> +++ b/dtprobed/dtprobed.c
> @@ -220,8 +220,10 @@ parse_dof(int in, int out)
>  		return ok;
>  
>  	dof = dof_copyin_dof(in, out, &ok);
> -	if (!dof)
> +	if (!dof) {
> +		free(dh);
>  		return ok;
> +	}
>  
>  	dof_parse(out, dh, dof);
>  
> -- 
> 2.39.1.268.g9de2f9a303
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel