[DTrace-devel] [PATCH v4 1/2] Implement the sched provider (first part)

Nick Alcock nick.alcock at oracle.com
Wed May 24 21:30:42 UTC 2023


On 24 May 2023, Kris Van Hees via DTrace-devel told this:

> diff --git a/test/unittest/sched/tst.lv-dequeue.r.p b/test/unittest/sched/tst.lv-dequeue.r.p
> new file mode 100755
> index 00000000..20978428
> --- /dev/null
> +++ b/test/unittest/sched/tst.lv-dequeue.r.p
> @@ -0,0 +1,6 @@
> +#!/usr/bin/awk -f
> +NR == 1 { next; }
> +NR == 2 && NF == 5 { $1 = "PROBE"; $4 = ""; gsub(/  +/, " "); print; next; }
> +NR == 2 && NF == 4 { $1 = "PROBE"; gsub(/  +/, " "); print; next; }
> +/^ *[0-9]+/ { exit; }
> +{ print; }
> diff --git a/test/unittest/sched/tst.lv-enqueue.r.p b/test/unittest/sched/tst.lv-enqueue.r.p
> diff --git a/test/unittest/sched/tst.lv-off-cpu.r b/test/unittest/sched/tst.lv-off-cpu.r
> diff --git a/test/unittest/sched/tst.lv-off-cpu.r.p b/test/unittest/sched/tst.lv-off-cpu.r.p
> diff --git a/test/unittest/sched/tst.lv-on-cpu.r.p b/test/unittest/sched/tst.lv-on-cpu.r.p
> diff --git a/test/unittest/sched/tst.lv-surrender.r.p b/test/unittest/sched/tst.lv-surrender.r.p
> diff --git a/test/unittest/sched/tst.lv-tick.r.p b/test/unittest/sched/tst.lv-tick.r.p
> diff --git a/test/unittest/sched/tst.lv-wakeup.r.p b/test/unittest/sched/tst.lv-wakeup.r.p

It's totally picky of me, but, given that these are quite complicated
and seem to be identical, maybe they should either be mostly symlinks or
all source a file in test/unittest/sched that implements the above? (We
already have tests that do both.)

-- 
NULL && (void)



More information about the DTrace-devel mailing list