[DTrace-devel] [PATCH v2] provider: support (opaque) private data for providers

[Eugene Loh]

On 5/18/23 22:34, Kris Van Hees wrote:

> On Thu, May 18, 2023 at 06:56:50PM -0400, Eugene Loh via DTrace-devel wrote:
>> I don't 100% understand, but:
>> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
>>
>> I'm curious, though.  The CPC provider has this comment:
>>         * FIXME: Memory pointed to by next_probe_map,
>> pfmname, and Dname
>>         * should ideally be freed explicitly during some
>> probe_destroy(),
>>         * but this is a low priority since all such memory
>> will be freed
>>                           * anyhow when the DTrace session ends.
>> Should there be a plan to address this FIXME?  Shall I compose a follow-up
>> patch?  Or, continue to defer to "the future"?
> It should be pretty easy to implement a 'destroy' callback function for this,
> so I think it is worth doing now.


Okay.  You or me?  I'm happy to do it, but just wanted to coordinate first.