[DTrace-devel] [PATCH 7/7] options: give the value of rejected options

[Nick Alcock]

On 14 May 2023, Kris Van Hees uttered the following:

> On Tue, May 02, 2023 at 06:12:22PM +0100, Nick Alcock via DTrace-devel wrote:
>> DTrace has long emitted error messages which complain about the value of
>> options being invalid without at any point saying what the rejected
>> value was.  This is needlessly unhelpful, and now that option error
>> handling is centralized, it's easy to fix.  Surprisingly, only one
>> test depends on the old behaviour.
>
> While this is useful behaviour, it is also not consistent with the behaviour
> that DTrace has presented in all previous versions.  So at a minimum, if we
> choose to go this route, we need to document this as a difference from what
> DTrace used to do.

Well, it's better error output. We already had numerous occasions in
which we improved error output and nobody ever complained then. Why is
it suddenly an issue now? Just because we have tests that check it?

I think you're being *way* too picky here.