[DTrace-devel] [PATCH 6/6] dtprobed: fix error message

[Kris Van Hees]

On Wed, Apr 19, 2023 at 04:41:31PM +0100, Nick Alcock via DTrace-devel wrote:
> The very first error emitted if the ioctl coming from the caller is
> somehow wrong has the expected and received sizes backwards. (The actual
> check is fine: only the error message is wrong.)
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  dtprobed/dtprobed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dtprobed/dtprobed.c b/dtprobed/dtprobed.c
> index 47dc1d3dc87a0..af647d92d3355 100644
> --- a/dtprobed/dtprobed.c
> +++ b/dtprobed/dtprobed.c
> @@ -387,7 +387,7 @@ helper_ioctl(fuse_req_t req, int cmd, void *arg,
>  			errmsg = "helper size incorrect";
>  			fuse_log(FUSE_LOG_ERR, "%i: dtprobed: %s: "
>  				 "expected at least %zi, not %zi\n", pid,
> -				 errmsg, in_bufsz, sizeof(dof_helper_t));
> +				 errmsg, sizeof(dof_helper_t), in_bufsz);
>  			goto fuse_err;
>  		}
>  		memcpy(&userdata->dh, in_buf, sizeof(dof_helper_t));
> -- 
> 2.39.1.268.g9de2f9a303
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel