[DTrace-devel] [PATCH 10/14] Consolidate more tvar and assoc code

[Nick Alcock]

On 3 May 2023, Eugene Loh via DTrace-devel told this:

>> +		emit(dlp,  BPF_MOV_REG(BPF_REG_4, isstore ? dnp->dn_reg : 0));
>
> That BPF_REG_4 line isn't quite right.  I replace it with

Oof! How did I not see that.

> +               if (isstore)
> +                       emit(dlp,  BPF_MOV_REG(BPF_REG_4, dnp->dn_reg));
> +               else
> +                       emit(dlp,  BPF_MOV_IMM(BPF_REG_4, 0));

Agreed.

>> +		emit(dlp,  BPF_MOV_REG(BPF_REG_3, isstore ? dnp->dn_reg : 0));
>
> Same issue with this BPF_REG_3 line.
>
> I'll assume your R-b is still good, but I'm happy to post a v2 of this patch if you like.

A quick audit for further instances of this shows none that I can see,
so you have my r-b still.