[DTrace-devel] [PATCH 1/2] tests: flowindent is no longer broken

Eugene Loh eugene.loh at oracle.com
Wed May 3 17:30:11 UTC 2023


I'm concerned.  I thought the behavior of this test was somewhat 
intermittent.  So what is the evidence that this test is now passing 
robustly?

On 5/3/23 12:23, Nick Alcock via DTrace-devel wrote:
> Fixed by the options rework, I think (not sure why, but I'm not going to
> look this particular gift horse in the mouth).
>
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>   test/unittest/options/tst.flowindent.d | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/test/unittest/options/tst.flowindent.d b/test/unittest/options/tst.flowindent.d
> index 8f8c2102749df..53dc38160c4d9 100644
> --- a/test/unittest/options/tst.flowindent.d
> +++ b/test/unittest/options/tst.flowindent.d
> @@ -4,7 +4,6 @@
>    * Licensed under the Universal Permissive License v 1.0 as shown at
>    * http://oss.oracle.com/licenses/upl.
>    */
> -/* @@xfail: flowindent is broken */
>   
>   /*
>    * ASSERTION: The -xflowindent option enables entry/return matching output.
>
> base-commit: f543fa6706c0b31364356c01bf3de63e3cce8ad1
> prerequisite-patch-id: fa667248b7b02e92ee6b3807123ebcf2ac0acc38
> prerequisite-patch-id: 0cec5f1a31d528a493d6143644c1e6b78c7f403b
> prerequisite-patch-id: 756ad5b8f08d5595c32dd113d742218991107746
> prerequisite-patch-id: eb290f098e38981181d85240150e1713979dc505
> prerequisite-patch-id: c25b38ab68e815a63f064aff7496408684f94a36
> prerequisite-patch-id: b86eb7e00b5883a586bd4dc7143ab25094912288
> prerequisite-patch-id: 6afb164d692c7489562e657ef3be3463ab84da2c
> prerequisite-patch-id: 85d3c176dc4a7105e4f04dbcdb4ccbdf18741795
> prerequisite-patch-id: 304017f7ef8a078214f6444ecbe0710f869bec71
> prerequisite-patch-id: 89cf4c6b9242525883ac02bb8ef90856ef908d0f
> prerequisite-patch-id: 0992642ac657a1da617588a6d7b28f3669960374
> prerequisite-patch-id: 23fdee31382d18dd3d79a269b24579639e8a3ce6
> prerequisite-patch-id: 2f7e015fa509baea3b4edd788a77eeb90ad2c6e7
> prerequisite-patch-id: 6d34ee30a210805080e50e9ec3aa6970fca2c1d6
> prerequisite-patch-id: 48eb5ab85cbfa71197a2ef40b3710effdd2f14a8
> prerequisite-patch-id: e20262c9dc602e53b2106c2a7b2f123d35960415
> prerequisite-patch-id: 8dfb0107d2426a8331b720609e38f80a05955cbb
> prerequisite-patch-id: f5ad43334c5271a78a025a7ffab37a84f24eb4dc
> prerequisite-patch-id: ea558305c200b093a1d9217079b50d223ed6699a
> prerequisite-patch-id: 631c8ec5d2da494d51f38a1b10fc1c0b3b951614



More information about the DTrace-devel mailing list