[DTrace-devel] [PATCH 13/14] test: Add string store_var()/load_var() tests for more than gvars

[Eugene Loh]

On 5/2/23 12:28, Nick Alcock wrote:

> On 2 May 2023, eugene loh stated:
>
>> From: Eugene Loh <eugene.loh at oracle.com>
>>
>> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> Reviewed-by: Nick Alcock <nick.alcock at oracle.com>
>
> with the usual comment-format nits.
>
>> @@ -9,14 +9,24 @@
>>   #pragma D option strsize=6
>>   #pragma D option quiet
>>   
>> -string	x;
> Why not change it to
>
> string	g;
It isn't needed.  Since the new test will have four different types of 
variables, it's easier (and reduces the maintenance cost) just to skip 
the declaration.