[DTrace-devel] [PATCH 10/14] Consolidate more tvar and assoc code

[Eugene Loh]

On 5/2/23 12:02, Nick Alcock wrote:

> On 2 May 2023, eugene loh uttered the following:
>> Subject: Re: [DTrace-devel] [PATCH 10/14] Consolidate more tvar and assoc code
> And here, "Consolidate tvar/assoc pointer generation".

Thanks.

> I appreciate the effect the previous code-motion commits had on
> increasing the readability of this commit: it's as easy to read as
> unified diff ever gets, and easy to prove it does what it says it does.
>
> Reviewed-by: Nick Alcock <nick.alcock at oracle.com>
>
> .. with one caveat:
>
>> -	if (dst->dn_ident->di_kind == DT_IDENT_ARRAY) {
>> +	if (idp->di_kind == DT_IDENT_ARRAY) {
>>   		/* associative arrays */
> This has effectively replaced the comment
>
>> -		/* Associative (global or TLS) array.  Cannot be in alloca space. */
> I'm fairly sure this comment is still accurate, and it's significantly
> more detailed. Maybe we should still use it.

Okay.  I added it.  That comment was in store_var() but not load_var().  
I went for the "common denominator" but the more detailed comment I 
suppose may be helpful (and accurate) in both cases.