[DTrace-devel] [PATCH 05/14] Call dt_cg_assoc_op() via dt_cg_load_var()
Nick Alcock
nick.alcock at oracle.com
Tue May 2 15:39:10 UTC 2023
On 2 May 2023, eugene loh told this:
> From: Eugene Loh <eugene.loh at oracle.com>
>
> To load a variable, we currently call dt_cg_assoc_op() for associative
> arrays and dt_cg_load_var() for all other types of variables. This is
> unfortunate since associative arrays and thread-local variables share
> a lot of code, and this sharing will increase once NULL strings are
> supported. Further, such splitting is a different model from
> dt_cg_store_var(), where all variable types are handled by a common
> function.
>
> Therefore, call dt_cg_assoc_op() via dt_cg_load_var(). Subsequent
> patches will inline the call and consolidate common code. This first
> step appears separately to clarify the changes.
Makes it much easier to review, thank you.
Reviewed-by: Nick Alcock <nick.alcock at oracle.com>
More information about the DTrace-devel
mailing list