[DTrace-devel] [PATCH 4/7] Add support for R_BPF_INSN_32 relocations

Eugene Loh eugene.loh at oracle.com
Thu Jul 27 23:16:00 UTC 2023


Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

But you've provided me off-line a helpful description of the motivation 
for this patch.  I think that would be a useful part of the commit message.

Also, in dt_dis_rtab(), I see:

                 switch (rp->dofr_type) {
                 case R_BPF_NONE:
                         tstr = "R_BPF_NONE";
                         break;
                 case R_BPF_64_64:
                         tstr = "R_BPF_INSN_64";
                         break;
                 case R_BPF_64_32:
                         tstr = "R_BPF_INSN_DISP32";
                         break;
                 default:
                         tstr = "R_???";
                 }

Does that DISP make sense?  (Sorry I don't understand this stuff better.)




More information about the DTrace-devel mailing list