[DTrace-devel] [PATCH 11/16] cpc: Skip cputrack and cpustat tests

eugene.loh at oracle.com eugene.loh at oracle.com
Fri Jan 27 02:23:24 UTC 2023


From: Eugene Loh <eugene.loh at oracle.com>

Also, the default event should be changed from PAPI_tot_ins to
cpu-clock.  At this point, there is no need to do so (after all,
the tests are being skipped), but the new comment is a reminder
that this is needed.

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
---
 test/unittest/cpc/err.cpcvscpustatpart1.sh   | 2 ++
 test/unittest/cpc/err.cpcvscpustatpart2.sh   | 2 ++
 test/unittest/cpc/err.cputrackfailtostart.sh | 3 ++-
 test/unittest/cpc/err.cputrackterminates.sh  | 3 ++-
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/test/unittest/cpc/err.cpcvscpustatpart1.sh b/test/unittest/cpc/err.cpcvscpustatpart1.sh
index 013f4ec2..4d3ddd41 100755
--- a/test/unittest/cpc/err.cpcvscpustatpart1.sh
+++ b/test/unittest/cpc/err.cpcvscpustatpart1.sh
@@ -13,6 +13,8 @@
 #       1) The system under test does not define the 'PAPI_tot_ins'
 #       generic event.
 
+# @@skip: no cpustat on Linux, and should switch PAPI_tot_ins to cpu-clock
+
 script()
 {
 	$dtrace -o $dtraceout -s /dev/stdin <<EOF
diff --git a/test/unittest/cpc/err.cpcvscpustatpart2.sh b/test/unittest/cpc/err.cpcvscpustatpart2.sh
index d68329e6..d565465b 100755
--- a/test/unittest/cpc/err.cpcvscpustatpart2.sh
+++ b/test/unittest/cpc/err.cpcvscpustatpart2.sh
@@ -13,6 +13,8 @@
 #       1) The system under test does not define the 'PAPI_tot_ins'
 #       generic event.
 
+# @@skip: no cpustat on Linux, and should switch PAPI_tot_ins to cpu-clock
+
 script()
 {
         $dtrace -s /dev/stdin <<EOF
diff --git a/test/unittest/cpc/err.cputrackfailtostart.sh b/test/unittest/cpc/err.cputrackfailtostart.sh
index 326a2e78..6b2b5fca 100755
--- a/test/unittest/cpc/err.cputrackfailtostart.sh
+++ b/test/unittest/cpc/err.cputrackfailtostart.sh
@@ -11,7 +11,8 @@
 #
 # The script will fail if:
 #	1) The system under test does not define the 'PAPI_tot_ins' event.
-#
+
+# @@skip: no cputrack on Linux, and should switch PAPI_tot_ins to cpu-clock
 
 script()
 {
diff --git a/test/unittest/cpc/err.cputrackterminates.sh b/test/unittest/cpc/err.cputrackterminates.sh
index 9d145448..ee644a92 100755
--- a/test/unittest/cpc/err.cputrackterminates.sh
+++ b/test/unittest/cpc/err.cputrackterminates.sh
@@ -11,7 +11,8 @@
 #
 # The script will fail if:
 #	1) The system under test does not define the 'PAPI_tot_ins' event.
-#
+
+# @@skip: no cputrack on Linux, and should switch PAPI_tot_ins to cpu-clock
 
 script()
 {
-- 
2.18.4




More information about the DTrace-devel mailing list