[DTrace-devel] [PATCH 4/4] test: Increase period in cpc allcpus test

[Kris Van Hees]

On Thu, Sep 07, 2023 at 06:39:24PM -0400, eugene.loh at oracle.com wrote:
> 
> Some kernels have problems with clock firings due to throttling.
> The CPC allcpus test uses a similar software event because that
> event is so ubiquitous.  But, while we have migrated many tests
> away from clock ticks due to their fickleness, this test inherently
> depends on this unfortunately unstable event.
> 
> Nevertheless, it seems that the problems with this event are
> mitigated when events fire less often, and we only need one
> firing per CPU for this test.
> 
> Therefore, increase the period.
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  test/unittest/cpc/tst.allcpus.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/unittest/cpc/tst.allcpus.sh b/test/unittest/cpc/tst.allcpus.sh
> index 90179d41..94304801 100755
> --- a/test/unittest/cpc/tst.allcpus.sh
> +++ b/test/unittest/cpc/tst.allcpus.sh
> @@ -18,14 +18,14 @@ mkdir -p $DIRNAME
>  cd $DIRNAME
>  
>  $dtrace $dt_flags -qn '
> -cpc:::cpu_clock-all-10000
> +cpc:::cpu_clock-all-1000000000
>  /cpus[cpu] != 1/
>  {
>  	cpus[cpu] = 1;
>  	printf("%d\n", cpu);
>  }
>  
> -tick-18s
> +tick-2s
>  {
>  	exit(0);
>  }' | awk 'NF != 0 {print}' | sort > dtrace.out
> -- 
> 2.18.4
> 
>