[DTrace-devel] [PATCH 1/3] Simplify an assertion

[Kris Van Hees]

On Thu, Dec 14, 2023 at 01:39:59PM -0500, eugene.loh at oracle.com wrote:
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... but I am going to squash it into the link_ntop patch because you are
    touching the code around that anyway.

Thanks for catching this silly assert condition!

> ---
>  libdtrace/dt_cg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
> index 11b7f5a1..7a84be5d 100644
> --- a/libdtrace/dt_cg.c
> +++ b/libdtrace/dt_cg.c
> @@ -4947,7 +4947,7 @@ dt_cg_subr_arg_to_tstring(dt_node_t *dnp, dt_irlist_t *dlp, dt_regset_t *drp,
>  
>  	TRACE_REGSET("    subr-arg_to_tstring:Begin");
>  
> -	assert(dnp->dn_ident && dnp->dn_ident);
> +	assert(dnp->dn_ident);
>  	isp = dnp->dn_ident->di_data;
>  	assert(isp && isp->dis_args);
>  	argtype = &isp->dis_args[0];
> -- 
> 2.18.4
> 
>