[DTrace-devel] [PATCH] test: fix err.* tests forcing XFAIL

[Nick Alcock]

On 1 Dec 2023, Kris Van Hees via DTrace-devel outgrape:

> Tests cam force an XFAIL condition by returning 67, but when that is
> used in err.* tests, it gets reported as XPASS.  It should report
> XFAIL no matter what.
>
> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> ---
>  runtest.sh | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/runtest.sh b/runtest.sh
> index ff0bc8db..7f9befb6 100755
> --- a/runtest.sh
> +++ b/runtest.sh
> @@ -1423,7 +1423,9 @@ for dt in $dtrace; do
>  
>              # Exitcode of 67 == XFAIL.
>              elif [[ $exitcode -eq 67 ]]; then
> +		[[ $expected_exitcode -eq 1 ]] && fail=t
>                  xfail=t
> +                failmsg="requested by test"

Something seems up with the indentation here. I think the first line is
using tabs for indentation, and it shouldn't be (since nothing else in
this file does)

Other than that, this seems good. (And having some kind of message
recorded seems like a good idea too.)

So, with that fixed,

Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

-- 
NULL && (void)