[DTrace-devel] [PATCH 1/3] Fix "missing braces" message with older compilers

Nick Alcock nick.alcock at oracle.com
Fri Dec 1 15:41:32 UTC 2023


On 1 Dec 2023, Kris Van Hees told this:

> I believe this fixes a problem that is reported by the GCC 4.8.5 compiler (default on OL7 it seems).  So -*really* pretty old.  I wouldn't
> worry about these compiler warnings, personally.  I'd rather not overly avoid them at the cost of code that could possibly be too
> implementation-dependent.

Agreed. If we're relying on GCC 4.8.5 warnings to find bugs in our code,
something is *really* wrong. Warnings from compilers that old are more
or less valueless and should probably just be ignored (but adding
machinery to identify such old compilers and turn them off is too much
overdesign even for me).



More information about the DTrace-devel mailing list