[DTrace-devel] [PATCH v2 04/04] rawtp: retrieve probe arguments from CTF data

[Nick Alcock]

On 30 Nov 2023, Kris Van Hees spake thusly:

> On Thu, Nov 30, 2023 at 08:26:33PM +0000, Nick Alcock wrote:
>> Hm. So this is assigned to the dt_probe_t's argv element, which is freed
>> in dt_probe_destroy() -- but unless it's done in an earlier patch in
>> this series, nothing frees dt_probe_t.argv[i].native, only the argv
>> array itself...
>> 
>> ... with that caveat, this looks good.
>
> That is a pre-existing issue with argument type data for probes.  Fixing that
> is not in the scope of this patch.  I'll work on a more generic solution for
> that because it is (1) a long-standing issue in DTrace (pre-dating the Linux
> version), and (2) an sisue at the level of probes in general - not a particular
> provider.

Makes sense. Indeed I seem to recall this popping out of valgrind memory
leak tests before now, a few bytes here, a few bytes there. (One
advantage of the no-waitfd series -- I think we can use a completely
stock valgrind now :) )

-- 
NULL && (void)