[DTrace-devel] [PATCH] Fix some inet_ntoa comments

Kris Van Hees kris.van.hees at oracle.com
Thu Aug 31 03:16:46 UTC 2023


On Mon, Aug 07, 2023 at 04:37:14PM -0400, eugene.loh at oracle.com via DTrace-devel wrote:
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  bpf/inet_ntoa.S | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/bpf/inet_ntoa.S b/bpf/inet_ntoa.S
> index 1ef3b13a..235005a5 100644
> --- a/bpf/inet_ntoa.S
> +++ b/bpf/inet_ntoa.S
> @@ -125,17 +125,17 @@ dt_inet_ntoa_write_uint8:
>   *     inp = *(fp + -4);
>   *     off = dt_inet_ntoa_write_uint8(inp, dst, off);
>   *     if (off >= STRSZ) goto done:
> - *     dst[off++] = ':';
> + *     dst[off++] = '.';
>   *
>   *     inp = *(fp + -3);
>   *     off = dt_inet_ntoa_write_uint8(inp, dst, off);
>   *     if (off >= STRSZ) goto done:
> - *     dst[off++] = ':';
> + *     dst[off++] = '.';
>   *
>   *     inp = *(fp + -2);
>   *     off = dt_inet_ntoa_write_uint8(inp, dst, off);
>   *     if (off >= STRSZ) goto done:
> - *     dst[off++] = ':';
> + *     dst[off++] = '.';
>   *
>   *     inp = *(fp + -1);
>   *     off = dt_inet_ntoa_write_uint8(inp, dst, off);
> -- 
> 2.18.4
> 
> 



More information about the DTrace-devel mailing list