[DTrace-devel] [PATCH 04/10] subr: tiny header tweak

[Kris Van Hees]

On Wed, Aug 02, 2023 at 02:26:54PM +0100, Nick Alcock via DTrace-devel wrote:
> I hunted down inclusions of <libgen.h> that weren't needed. Most were in
> code I was touching anyway, but this one was independent.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... but you might want to mention why this matters, i.e. what that include
file was for and why we do not need it here.  It is pretty obscure since it
involves the POSIX vs GNU implementation of basename() (and that function is
not used in this file).

> ---
>  libdtrace/dt_subr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libdtrace/dt_subr.c b/libdtrace/dt_subr.c
> index 300c1a8d7b0c..a7b56afd5903 100644
> --- a/libdtrace/dt_subr.c
> +++ b/libdtrace/dt_subr.c
> @@ -18,7 +18,6 @@
>  #include <ctype.h>
>  #include <alloca.h>
>  #include <assert.h>
> -#include <libgen.h>
>  #include <limits.h>
>  #include <sys/ioctl.h>
>  #include <port.h>
> -- 
> 2.41.0.270.g68fa1d84b5
> 
>