[DTrace-devel] [PATCH 0/6] a few little bugfixes and test fixes

Nick Alcock nick.alcock at oracle.com
Wed Apr 19 15:41:25 UTC 2023


These commits are a bunch of stuff built up while I was working on USDT
is-enabled. None are necessary for it, but I think they're worth
lookiing at anyway.

The new test for libctf bug 30264 is possibly debatable: it's a test for
a bug in *upstream binutils* which impacts DTrace.  Thus it is expected
to fail in some environments which don't have a fix for that bug yet
(which is every single one right now, but this will change shortly when
I do the backport and as it filters into other environments). It's
possible we don't actually want to test for bugs in upstream components
like this, even if they do affect DTrace and we have a reproducible
testcase. I'm not sure.

The symbol bug is old and is pretty hard to reproduce: I basically gave
up trying. The only way I found to repro it involved seriously messed-up
kernel CTF missing basic types that the C or D dicts reference. It's a
bug anyway, I fixed it.

The module loader thing fixes a few tests that actually rely on
particular kernel modules being loaded: when the old loader was ripped
out of runtest, we lost the ability to load them. The new loader is much
simpler :)

Nick Alcock (6):
  test: add back a simple module loader.
  test: add a test for libctf bug 30264
  build: add gdb and valgrind support to the run-dtrace wrapper
  symbol: fix undefined, non-extern symbols
  drti: drop misleading comment
  dtprobed: fix error message

 cmd/Build                                     | 12 +++++--
 dtprobed/dtprobed.c                           |  2 +-
 libdtrace/drti.c                              | 10 +-----
 libdtrace/dt_module.c                         |  5 ++-
 runtest.sh                                    | 10 ++++++
 test/modules                                  | 12 ++-----
 test/unittest/scalars/tst.misc.d              |  1 -
 test/unittest/scalars/tst.misc.x              | 11 +++++++
 .../types/tst.nested-unnamed-structs.d        | 32 +++++++++++++++++++
 .../types/tst.nested-unnamed-structs.x        |  7 ++++
 10 files changed, 78 insertions(+), 24 deletions(-)
 create mode 100755 test/unittest/scalars/tst.misc.x
 create mode 100644 test/unittest/types/tst.nested-unnamed-structs.d
 create mode 100755 test/unittest/types/tst.nested-unnamed-structs.x


base-commit: f543fa6706c0b31364356c01bf3de63e3cce8ad1
-- 
2.39.1.268.g9de2f9a303




More information about the DTrace-devel mailing list