[DTrace-devel] [PATCH] test: Bump up locked memory in lockmem tests

[Kris Van Hees]

On Fri, Sep 09, 2022 at 04:49:55PM -0400, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> The default aggsize is 4M.  This is the dominant drain on locked
> memory for a simple script like "BEGIN { @ = avg(1) }".
> 
> The lockmem tests check behavior when the lockmem limit is too
> small; anything less than 4M is suitable.
> 
> They also check when the lockmem limit is large enough.  We were
> using a lockmem limit of 16M, which is clearly inadequate even
> for only a few CPUs.
> 
> Bump the "large enough" sizes up to 256M, which should be sufficient
> even for dozens of CPUs.
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... and already on dev

> ---
>  test/unittest/misc/tst.lockmem-cmdline.sh | 2 +-
>  test/unittest/misc/tst.lockmem-envvar.sh  | 2 +-
>  test/unittest/misc/tst.lockmem-pragma.sh  | 2 +-
>  test/unittest/misc/tst.lockmem-x.sh       | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/test/unittest/misc/tst.lockmem-cmdline.sh b/test/unittest/misc/tst.lockmem-cmdline.sh
> index f7303ec1..64b5096c 100755
> --- a/test/unittest/misc/tst.lockmem-cmdline.sh
> +++ b/test/unittest/misc/tst.lockmem-cmdline.sh
> @@ -8,7 +8,7 @@
>  
>  dtrace=$1
>  
> -for val in 1 16384 unlimited; do
> +for val in 1 262144 unlimited; do
>  	ulimit -l $val
>  
>  	$dtrace -qn 'BEGIN { @ = avg(1234); exit(0); }'
> diff --git a/test/unittest/misc/tst.lockmem-envvar.sh b/test/unittest/misc/tst.lockmem-envvar.sh
> index 8b1946d7..735516d0 100755
> --- a/test/unittest/misc/tst.lockmem-envvar.sh
> +++ b/test/unittest/misc/tst.lockmem-envvar.sh
> @@ -10,7 +10,7 @@ dtrace=$1
>  
>  ulimit -l 1
>  
> -for val in 16 1K 16384K 16M unlimited; do
> +for val in 16 1K 262144K 256M unlimited; do
>  	DTRACE_OPT_LOCKMEM=$val $dtrace -qn 'BEGIN { @ = avg(1234); exit(0); }'
>  	echo $?
>  done
> diff --git a/test/unittest/misc/tst.lockmem-pragma.sh b/test/unittest/misc/tst.lockmem-pragma.sh
> index 05963f00..03aacaf5 100755
> --- a/test/unittest/misc/tst.lockmem-pragma.sh
> +++ b/test/unittest/misc/tst.lockmem-pragma.sh
> @@ -10,7 +10,7 @@ dtrace=$1
>  
>  ulimit -l 1
>  
> -for val in 16 1K 16384K 16M unlimited; do
> +for val in 16 1K 262144K 256M unlimited; do
>  	$dtrace -qs /dev/stdin << EOF
>  		#pragma D option lockmem=$val
>  
> diff --git a/test/unittest/misc/tst.lockmem-x.sh b/test/unittest/misc/tst.lockmem-x.sh
> index de5e583f..b70bd285 100755
> --- a/test/unittest/misc/tst.lockmem-x.sh
> +++ b/test/unittest/misc/tst.lockmem-x.sh
> @@ -10,7 +10,7 @@ dtrace=$1
>  
>  ulimit -l 1
>  
> -for val in 16 1K 16384K 16M unlimited; do
> +for val in 16 1K 262144K 256M unlimited; do
>  	$dtrace -xlockmem=$val -qn 'BEGIN { @ = avg(1234); exit(0); }'
>  	echo $?
>  done
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel