[DTrace-devel] [PATCH v2 4/5] test: fix test/demo/user/libc.d

[Kris Van Hees]

On Thu, Sep 08, 2022 at 12:23:16PM -0400, Eugene Loh via DTrace-devel wrote:
> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
> Add an explanation why s/::/:m*:/ maybe?
> The "@@trigger: none" thing is fine, but I'm curious:  do we normally handle
> this by naming the test "tst.*"?

Sadly, it seems like the test passes on Debian but not on OL8.  I think that
-c support is having issues.  I'll look to see if I can rewrite the test to
not depend on -c so that we at least can test the functionality that this test
exists for.

Stay tuned...

> On 9/7/22 16:15, Kris Van Hees via DTrace-devel wrote:
> > It seems that /bin/date is more likely to exist than /usr/bin/date.
> > Also, the test needs a '@@trigger: none' marker to ensure it actually
> > gets executed.
> > 
> > Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> > ---
> >   test/demo/user/libc.d | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/test/demo/user/libc.d b/test/demo/user/libc.d
> > index dad274b8..cc1276af 100644
> > --- a/test/demo/user/libc.d
> > +++ b/test/demo/user/libc.d
> > @@ -5,9 +5,10 @@
> >    * http://oss.oracle.com/licenses/upl.
> >    */
> > -/* @@runtest-opts: -c /usr/bin/date */
> > +/* @@runtest-opts: -c /bin/date */
> > +/* @@trigger: none */
> > -pid$target:libc.so::entry
> > +pid$target:libc.so:m*:entry
> >   {
> >   	@[probefunc] = count();
> >   }
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel