[DTrace-devel] [PATCH v3 21/22] pid: drop more Solaris-specific bug workarounds

Nick Alcock nick.alcock at oracle.com
Thu Sep 8 14:52:00 UTC 2022


We definitely don't have any old binaries that exhibit a problem only
observed on old versions of Solaris lacking modern ELF constructors.

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
---
 libdtrace/dt_pid.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/libdtrace/dt_pid.c b/libdtrace/dt_pid.c
index bcde6c68eda2..888fc9b143ee 100644
--- a/libdtrace/dt_pid.c
+++ b/libdtrace/dt_pid.c
@@ -270,16 +270,6 @@ dt_pid_sym_filt(void *arg, const GElf_Sym *symp, const char *func)
 	if (pp->dpp_last_taken == 0 ||
 	    symp->st_value != pp->dpp_last.st_value ||
 	    symp->st_size != pp->dpp_last.st_size) {
-		/*
-		 * Due to 4524008, _init and _fini may have a bloated st_size.
-		 * While this bug has been fixed for a while, old binaries
-		 * may exist that still exhibit this problem. As a result, we
-		 * don't match _init and _fini though we allow users to
-		 * specify them explicitly.
-		 */
-		if (strcmp(func, "_init") == 0 || strcmp(func, "_fini") == 0)
-			return 0;
-
 		/*
 		 * Versioned identifiers are a problem.
 		 */
-- 
2.37.1.265.g363c192786.dirty




More information about the DTrace-devel mailing list