[DTrace-devel] [PATCH 4/5] test: fix test/demo/user/libc.d

Nick Alcock nick.alcock at oracle.com
Wed Sep 7 14:58:13 UTC 2022


On 7 Sep 2022, Kris Van Hees via DTrace-devel stated:

> Most distributions support /bin/date whereas some only support /bin/date.

Um, that's a bit confusing :P

But yes, for old non-unified-/usr systems, /bin/date is probably more
likely to exist than /usr/bin/date (though every system I can see has
a symlink in the one place point to the other).

> Mark the test as '@@skip' for now because probe* bvars are broken for pid
> probes.

They're not meant to be, and surely @@xfail is more appropriate, or
we'll just forget to unskip this. (This neither crashes the system nor
takes a long time, so @@xfail...)

> -/* @@runtest-opts: -c /usr/bin/date */
> +/* @@runtest-opts: -c /bin/date */
> +/* @@trigger: none */
> +/* @@skip: probefunc and other probe* bvars are broken for pid probes */
>  
> -pid$target:libc.so::entry
> +pid$target:libc.so:m*:entry

This'll need later changes anyway, since "libc.so" is the wrong name and
we can't use globs there yet...

-- 
NULL && (void)



More information about the DTrace-devel mailing list