[DTrace-devel] [PATCH 3/3] test: Add @@nosort tag to agg tests that check sort order

[Kris Van Hees]

On Thu, Sep 01, 2022 at 01:32:36PM -0400, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... queued for dev

> ---
>  test/unittest/aggs/tst.keysort.d         | 3 +++
>  test/unittest/aggs/tst.llquantize_sort.d | 2 ++
>  test/unittest/aggs/tst.llquantsortkey.d  | 2 ++
>  test/unittest/aggs/tst.llquantsortsum.d  | 2 ++
>  test/unittest/aggs/tst.llquantsortzero.d | 2 ++
>  test/unittest/aggs/tst.neglquant.d       | 2 ++
>  test/unittest/aggs/tst.signedkeys.d      | 2 ++
>  test/unittest/aggs/tst.signedkeyspos.d   | 2 ++
>  test/unittest/aggs/tst.valsortkeypos.d   | 2 ++
>  9 files changed, 19 insertions(+)
> 
> diff --git a/test/unittest/aggs/tst.keysort.d b/test/unittest/aggs/tst.keysort.d
> index a8213bf2..ef01a0a3 100644
> --- a/test/unittest/aggs/tst.keysort.d
> +++ b/test/unittest/aggs/tst.keysort.d
> @@ -5,6 +5,9 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@nosort */
> +/* @@xfail: need setopt() support */
> +
>  #pragma D option quiet
>  
>  BEGIN
> diff --git a/test/unittest/aggs/tst.llquantize_sort.d b/test/unittest/aggs/tst.llquantize_sort.d
> index a0ad648c..2dc3dde5 100644
> --- a/test/unittest/aggs/tst.llquantize_sort.d
> +++ b/test/unittest/aggs/tst.llquantize_sort.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@nosort */
> +
>  /*
>   * ASSERTION:
>   *  llquantize() output is sorted correctly by:
> diff --git a/test/unittest/aggs/tst.llquantsortkey.d b/test/unittest/aggs/tst.llquantsortkey.d
> index 43cc6461..73f18d61 100644
> --- a/test/unittest/aggs/tst.llquantsortkey.d
> +++ b/test/unittest/aggs/tst.llquantsortkey.d
> @@ -14,6 +14,8 @@
>   *
>   */
>  
> +/* @@nosort */
> +
>  #pragma D option quiet
>  
>  BEGIN
> diff --git a/test/unittest/aggs/tst.llquantsortsum.d b/test/unittest/aggs/tst.llquantsortsum.d
> index 7294c50b..302890f6 100644
> --- a/test/unittest/aggs/tst.llquantsortsum.d
> +++ b/test/unittest/aggs/tst.llquantsortsum.d
> @@ -13,6 +13,8 @@
>   *
>   */
>  
> +/* @@nosort */
> +
>  #pragma D option quiet
>  
>  BEGIN
> diff --git a/test/unittest/aggs/tst.llquantsortzero.d b/test/unittest/aggs/tst.llquantsortzero.d
> index 4bfc7f09..df2fdaaf 100644
> --- a/test/unittest/aggs/tst.llquantsortzero.d
> +++ b/test/unittest/aggs/tst.llquantsortzero.d
> @@ -13,6 +13,8 @@
>   *
>   */
>  
> +/* @@nosort */
> +
>  #pragma D option quiet
>  
>  BEGIN
> diff --git a/test/unittest/aggs/tst.neglquant.d b/test/unittest/aggs/tst.neglquant.d
> index 63e3796b..c09d7aab 100644
> --- a/test/unittest/aggs/tst.neglquant.d
> +++ b/test/unittest/aggs/tst.neglquant.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@nosort */
> +
>  #pragma D option quiet
>  
>  BEGIN
> diff --git a/test/unittest/aggs/tst.signedkeys.d b/test/unittest/aggs/tst.signedkeys.d
> index be2a55dd..b40cad6f 100644
> --- a/test/unittest/aggs/tst.signedkeys.d
> +++ b/test/unittest/aggs/tst.signedkeys.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@nosort */
> +
>  /*
>   * ASSERTION:
>   * 	Signed integer keys print and sort as expected.
> diff --git a/test/unittest/aggs/tst.signedkeyspos.d b/test/unittest/aggs/tst.signedkeyspos.d
> index 9530ab5c..7d7d6486 100644
> --- a/test/unittest/aggs/tst.signedkeyspos.d
> +++ b/test/unittest/aggs/tst.signedkeyspos.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@nosort */
> +
>  /*
>   * ASSERTION:
>   * 	Signed integer keys print and sort as expected using the
> diff --git a/test/unittest/aggs/tst.valsortkeypos.d b/test/unittest/aggs/tst.valsortkeypos.d
> index d1de72b4..b457d86b 100644
> --- a/test/unittest/aggs/tst.valsortkeypos.d
> +++ b/test/unittest/aggs/tst.valsortkeypos.d
> @@ -5,6 +5,8 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> +/* @@nosort */
> +
>  /*
>   * ASSERTION:
>   * 	aggsortkeypos option works when sorting by values, values are
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel