[DTrace-devel] [PATCH 20/26] libcommon: add uprobe_name() and uprobe_delete()

Nick Alcock nick.alcock at oracle.com
Mon Oct 24 10:51:40 UTC 2022


On 21 Oct 2022, Kris Van Hees via DTrace-devel uttered the following:

> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>

Nice refactoring!

Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

> +	if (asprintf(&name, "dt_pid/%c_%llx_%llx_%lx", isret ? 'r' : 'p',
> +		     (unsigned long long)dev, (unsigned long long)ino,
> +		     (unsigned long)addr) < 0)
> +		return NULL;

(confirmed that this resolves to the same thing as it did before, so the
parser in dt_pid.c will still work.)



More information about the DTrace-devel mailing list