[DTrace-devel] [PATCH v4 12/25] libproc: fix double-free on error path

Kris Van Hees kris.van.hees at oracle.com
Sat Oct 8 03:20:39 UTC 2022


On Fri, Oct 07, 2022 at 11:25:11AM +0100, Nick Alcock via DTrace-devel wrote:
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  libproc/Psymtab.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libproc/Psymtab.c b/libproc/Psymtab.c
> index 3e2f08928eca..763520a6427d 100644
> --- a/libproc/Psymtab.c
> +++ b/libproc/Psymtab.c
> @@ -1505,7 +1505,6 @@ elf_bad_noaddr:
>  	    "likely broken: %s\n", fptr->file_pname, (err == 0) ? "<null>" :
>  	    elf_errmsg(err));
>  	fptr->file_dyn_base = 0;
> -	free(cache);
>  	*jmp_pad = old_exec_jmp;
>  	return;
>  
> -- 
> 2.35.1
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel



More information about the DTrace-devel mailing list