[DTrace-devel] [PATCH v2 02/20] drti: emit into a subdirectory

[Nick Alcock]

On 15 Sep 2022, Kris Van Hees stated:

> On Wed, Sep 07, 2022 at 01:59:51PM +0100, Nick Alcock via DTrace-devel wrote:
>> The BPF library code assumes that ${libdir}/dtrace/*.o are all BPF
>> object files.  drti*.o is not, and its presence causes the BPF code to
>> fail at DTrace startup time.
>
> This needs some rephrasing because drti*.o is not causing any BPF code to fail.
> What fails is that the code that loads precompiled BPF object files (correctly)
> does not recognize drti*.o as compiled BPF code.  And it expects all .o files
> in that directory to be compiled BPF code.

Ugh, yeah, I meant 'the BPF library loader'. Fixed.

>> Move it into a subdirectory to keep it out of trouble.
>
> That is one solution.  I guess you also could have modified the code that loads
> precompiled BPF objects to ignore .o files that are not compiled BPF code.

I suppose so -- and if we gain more .o's that are native non-BPF code in
there, that probably makes sense to switch to.

-- 
NULL && (void)