[DTrace-devel] [PATCH v2 06/20] uapi headers: include <sys/dtrace_types> as needed

Nick Alcock nick.alcock at oracle.com
Thu Oct 6 12:20:15 UTC 2022


On 16 Sep 2022, Kris Van Hees stated:

> On Wed, Sep 07, 2022 at 01:59:54PM +0100, Nick Alcock via DTrace-devel wrote:
>> diff --git a/test/internals/headers/tst.header-endianness.sh b/test/internals/headers/tst.header-endianness.sh
>> new file mode 100755
>> index 000000000000..18c3fb0b26be
>> --- /dev/null
>> +++ b/test/internals/headers/tst.header-endianness.sh
>> @@ -0,0 +1,29 @@
>> +#!/bin/bash
>> +#
>> +# Oracle Linux DTrace.
>> +# Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
>> +# Licensed under the Universal Permissive License v 1.0 as shown at
>> +# http://oss.oracle.com/licenses/upl.
>> +#
>> +
>> +set -e
>> +
>> +dtrace=$1
>> +CC=/usr/bin/gcc
>> +OLDDIRNAME=`pwd`
>> +CFLAGS="-I${PWD}/include"
>
> When looiking at the compiler invocation below, I don't see hos this is going
> to work.  Or even how it can work on your system.  The sys/dtrace_types.h file
> is found in uts/common in the source tree and /usr/include when installed.

Er, oops. I didn't think of the installed case! However, this test is
more or less useless outside the source tree -- it's a development test
only, and doesn't test anything relevant to a running DTrace.

Fixed in the next round, I think (by suppressing invocation outside the
installed tree, using a new tag).

-- 
NULL && (void)



More information about the DTrace-devel mailing list