[DTrace-devel] [PATCH] install: defend against install-time clock skew

[Nick Alcock]

If the build machine is using a remote filesystem with a skewed clock,
'make install' will trigger a complete rebuild (possibly with different
options etc than the original build).

We went to some care to not depend 'make install' on anything -- with
one exception.  test/triggers/Build contains an install-test rule that
depends on triggers, which pulls in libproc-pldd, which pulls in
libdtrace, and now we're rebuilding everything.

Rip out this dependency.  (If rebuilding was really needed, this rule is
the wrong place to do it from anyway: and if no building has happened at
all the installation will have failed long before now.)

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
---
 test/triggers/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/triggers/Build b/test/triggers/Build
index c3afb175639f..4538a5c10359 100644
--- a/test/triggers/Build
+++ b/test/triggers/Build
@@ -30,7 +30,7 @@ TRIGGERS = $(EXTERNAL_TRIGGERS) $(INTERNAL_TRIGGERS)
 
 TRIGGER_SOLIBS = libproc-dlmlib libproc-lookup-victim-lib
 
-install-test:: triggers
+install-test::
 	$(call describe-install-target,$(INSTTESTDIR)/test/triggers,$(SCRIPT_TRIGGERS))
 	mkdir -p $(INSTTESTDIR)/test/triggers
 	install -m 755 $(addprefix test/triggers/,$(SCRIPT_TRIGGERS)) $(INSTTESTDIR)/test/triggers
-- 
2.38.0.266.g481848f278