[DTrace-devel] [PATCH 3/3] daemon: support libfuse 2

[Nick Alcock]

On 8 Nov 2022, Nick Alcock verbalised:

> On 8 Nov 2022, Kris Van Hees said:
>>> +static void
>>> +old_fuse_init(struct fuse_session *cuse_session) {}
>>
>> Since you use conditionals based on HAVE_FUSE2 below already anyway, why not
>> just drop this and in setup_helper_device() place the call to old_fuse_init()
>> under #ifndef HAVE_FUSE3?  And rename that function (see below)...
>
> Just something I learned from GNU: whenever possible avoid doing that
> sort of thing, it's *ugly*. (The only reason I did it with
> HAVE_FUSE_NUMA inside libfuse 2's loop() is that I consider all of that
> obsolete code even though I only just wrote it, and eventually it will
> go away and take its ugliness with it.)

Ok so on inspecting the codebase I violate this alleged rule so much
that it's inconsistent to stick with it here. Conditionals at site of
use it is! (Oops.)