[DTrace-devel] [PATCH 4/7 v3 REVIEWED] Add support for built-in variable args

[Eugene Loh]

Adding a trigger (destructive + system()) makes sense to me for tst.*, 
but I don't understand it for the err.*.  Why would we want these tests 
to run?  Shouldn't they just be /* @@runtest-opts: -e */?

On 5/27/22 23:01, Kris Van Hees via DTrace-devel wrote:
> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
>
> diff --git a/test/unittest/variables/bvar/err.D_ARGS_IDX.args-neg-idx.d b/test/unittest/variables/bvar/err.D_ARGS_IDX.args-neg-idx.d
> +#pragma D option quiet
> +#pragma D option destructive
> +
> +BEGIN
> +{
> +	system("echo write something > /dev/null");
> +}
> +
> +write:entry {
> +	trace(args[-1]);
> +	exit(0);
> +}
> +
> +ERROR {
> +	exit(1);
> +}
> diff --git a/test/unittest/variables/bvar/err.D_ARGS_IDX.args-too-many.d b/test/unittest/variables/bvar/err.D_ARGS_IDX.args-too-many.d
> +#pragma D option quiet
> +#pragma D option destructive
> +
> +BEGIN
> +{
> +	system("echo write something > /dev/null");
> +}
> +
> +write:entry {
> +	trace(args[0]);
> +	trace(args[1]);
> +	trace(args[2]);
> +	trace(args[3]);
> +	exit(0);
> +}
> +
> +ERROR {
> +	exit(1);
> +}