[DTrace-devel] [PATCH 5/7] Add support for built-in variable args

[Eugene Loh]

I don't know if this belongs in the patch 5 review or patch 6 but...

On 5/27/22 09:29, Eugene Loh wrote:
>
> *)  Why are there no tests (other than disasm and err)?  One argument 
> could be
>     because SDT args are not yet populated... patch 6.  But syscall 
> apparently
>     has typed args.  After all,
>     test/unittest/variables/bvar/err.D_ARGS_IDX.args-too-many.d 
> requires it.

For example, tst.args-match-argN in patch 6 works with patch 5 (that is, 
without applying patch 6).  So that test (which has nothing to do with 
SDT, the subject of patch 6) should be moved back into patch 5 (assuming 
syscall args[] is a thing).

BUT that test needs a trigger.  One cannot (I would think) just assume 
that write:entry will trigger by itself.  In fact, the test hung when I 
tried it (unless I hit <RET> or something while the test was running).