[DTrace-devel] [PATCH 12/20] dlibs: improve load-time errors

[Eugene Loh]

Would it make sense to include a test?

On 5/11/22 14:12, Nick Alcock via DTrace-devel wrote:
> This corrects errors you get at BPF dlib load time from
>
> dtrace: failed to compile script X: Success
>
> to e.g.
>
> dtrace: failed to compile script X: undefined symbol DTRACEFLT_BADADDR in BPF dlib
>
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>   libdtrace/dt_dlibs.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/libdtrace/dt_dlibs.c b/libdtrace/dt_dlibs.c
> index 89ea062d5e17..8bc88399bf2c 100644
> --- a/libdtrace/dt_dlibs.c
> +++ b/libdtrace/dt_dlibs.c
> @@ -103,6 +103,7 @@ dt_dlib_error(dtrace_hdl_t *dtp, int eid, const char *format, ...)
>   
>   	va_start(ap, format);
>   	dt_set_errmsg(dtp, dt_errtag(eid), NULL, NULL, 0, format, ap);
> +	dt_set_errno(dtp, EDT_BPF);
>   	va_end(ap);
>   }
>