[DTrace-devel] [PATCH v3 11/19] tests: always check expected results as text, not binary

[Kris Van Hees]

On Thu, Mar 24, 2022 at 06:24:37PM +0000, Nick Alcock via DTrace-devel wrote:
> Even if we get \0 in results, we want to see the output, not helpful
> "binary files differ" messages.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... but let's put this on the 'dev' branch outside of this patch series because
it really does not belong in the series.

> ---
>  runtest.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/runtest.sh b/runtest.sh
> index 1495285dd29d..41a1335b66b7 100755
> --- a/runtest.sh
> +++ b/runtest.sh
> @@ -507,7 +507,7 @@ resultslog()
>          elif [[ -n $want_expected_diff ]]; then
>              log "Diff against expected:\n"
>  
> -            diff -u $rfile $tmpdir/test.out | tee -a $LOGFILE >> $SUMFILE
> +            diff -au $rfile $tmpdir/test.out | tee -a $LOGFILE >> $SUMFILE
>          fi
>      fi
>  
> -- 
> 2.35.1.261.g8402f930ba.dirty
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel