[DTrace-devel] [PATCH v2 15/17] bpf: don't throw away CTF errors when setting task offsets

[Nick Alcock]

On 23 Mar 2022, Eugene Loh via DTrace-devel spake thusly:

> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
>
> On 3/14/22 5:30 PM, Nick Alcock wrote:
>> The first type lookup done after translators are parsed is the set done
>> to look up task offsets.  If something is wrong with the CTF and the
>> translators are missing, these lookups are likely to fail -- but
>> since we don't set dt_ctferr, the actual error is discarded and
>> the only thing reported to the user is "unknown CTF error".
>> Not even CTF debugging helps.
>>
>> Fix trivial.
>
> "The fix is trivial."  Or better yet, just omit that assessment: the short patch speaks for itself.

Dropped. (I seem to have a habit of saying "Fix trivial": I was going to
say oohh it's used in *lots* of other projects, and then I grepped
around, and, uh, yes, it is, by, um, me. And nobody else. I know I got
this stereotyped phrase from somewhere where it was in very common use,
but I'm not sure where. I thought it was GCC, but it isn't...)